Template talk:Item: Difference between revisions

From Bulbapedia, the community-driven Pokémon encyclopedia.
Jump to navigationJump to search
Line 90: Line 90:
::::::::::I was assuming you had an external editor like Notepad++ which tells you line numbers (and has other cool features).
::::::::::I was assuming you had an external editor like Notepad++ which tells you line numbers (and has other cool features).
::::::::::As it is now, it looks like mine should work for all rows that I know about: Effect row, optional Secondary Effect row, optional Description row, optional Notes row, and optional "please see the main article" row. If there are any others, I'm sure the person to do the actual change knows of them. <b>~ [[User:Ribose|<span style="color:green" title="user">Ribose</span>]] · [[User talk:Ribose|<span style="color:blue" title="talk">talk</span>]] · [[Special:Contributions/Ribose|<span style="color:blue" title="contributions">cntr</span>]] ·</b> 15:47, 22 May 2011 (UTC)
::::::::::As it is now, it looks like mine should work for all rows that I know about: Effect row, optional Secondary Effect row, optional Description row, optional Notes row, and optional "please see the main article" row. If there are any others, I'm sure the person to do the actual change knows of them. <b>~ [[User:Ribose|<span style="color:green" title="user">Ribose</span>]] · [[User talk:Ribose|<span style="color:blue" title="talk">talk</span>]] · [[Special:Contributions/Ribose|<span style="color:blue" title="contributions">cntr</span>]] ·</b> 15:47, 22 May 2011 (UTC)
:::::::::::Sorry, I completely forgot about this. Thanks to Firebug, I could see for myself that you were right, so I added it in. <span class="sc">[[User:Werdnae|<span style="color:#2D4B98;">Werdnae</span>]]</span> <small>[[User talk:Werdnae|<span style="color:#009000;">(talk)</span>]]</small> 01:39, 22 July 2011 (UTC)

Revision as of 01:39, 22 July 2011

May I make a suggestion? Can you possible remove the centering affect from the item name, so both the name and the J!characters are flush to the left instead of centerized according to the second line? Centering is fine for single-item entries, such as the template example itself, but when you're reading the boxes in an list-format (such as the Gen2 Berry page), it's horribly unaesthetic and sloppy-looking. Luna Tiger * the Arc Toraph 16:45, 20 February 2010 (UTC)

Why not edit it yourself? SpecialK Leiks Lucario and The Celebi Glitch 17:36, 20 February 2010 (UTC)
Oh right you cant. *calls admin* SpecialK Leiks Lucario and The Celebi Glitch 17:36, 20 February 2010 (UTC)

Fling

How about a Fling parameter? For the power at least, because the added effect of Flame Orb etc. can go in the secondary effect. --SnorlaxMonster 23:23, 30 March 2010 (UTC)

Sorta eh on that. Fling's just one move, where everything's listed. TTEchidna 00:13, 31 March 2010 (UTC)

Pokéwalker

Because of the large number of items found through the Pokéwalker, can there be a separate section for the Pokéwalker location? --SnorlaxMonster 11:15, 7 April 2010 (UTC)

Stadium 2 descriptions

Stadium 2 has unique descriptions for all Gen I items (the descriptions for Gen II items are the same as in GSC). I think that a field for Stadium 2 descriptions should be added to this template. I can put them in into respective articles. --Maxim 14:48, 16 May 2010 (UTC)

Doesn't the first Stadium game have descriptions as well? I believe that was the first Pokémon game to have descriptions for anything at all. In which case, there should be a section for Stadium 1 as well. --Blaziken257 15:13, 16 May 2010 (UTC)
I haven't seen any item descriptions for Stadium 1. The descriptions in Stadium 2 appear in Earl's Pokemon Academy Library and Stadium 1 doesn't have it. But they might be listed in some other place in Stadium 1 that I have never noticed. --Maxim 15:32, 16 May 2010 (UTC)
IIRC, you can see item (and move) descriptions in Stadium 1 (as well as Stadium 2) if you go to Prof. Oak's lab (the feature you can view and store Pokémon from your Game Boy games, among other things). I haven't played it in a long time, so my memory here is faint, but I believe that I'm right. --Blaziken257 15:36, 16 May 2010 (UTC)

Colosseum and XD

I've recently tried to start converting the item fields on List of key items in Pokémon Colosseum and List of key items in Pokémon XD: Gale of Darkness to the same style used on the other key item pages. However, I've hit a snag. There's no coding to allow an item description from either Colosseum or XD: Gale of Darkness display as listing it from the right game. The lack of item minisprites in those games can be worked around easily, but without fields for Colosseum and XD, there's no way to put in the item descriptions and label them honestly. And since I got put on probation back on May 1, I don't have access to my sysop powers, so I can't make the necessary adjustments myself. Can anybody help me? Thanks. --Shiningpikablu252 17:56, 18 May 2010 (UTC)

Better amend this request. I really think Cologne could use this template, but in order to do so, the template needs a description field that can accomodate both Colosseum and XD since each of the individual scents have the same description in both games--"A scent that [slightly/(nothing in between)/greatly] pleases Pokémon". The fact that the template doesn't already have full support for the Gamecube games (only locations are supported, not descriptions, and the Gamecube games do have item descriptions that this template needs to support but doesn't) is quite disturbing, to be honest...--Shiningpikablu252 03:26, 3 August 2010 (UTC)
I'd do it, Pikablu, but this template scares me. Get the Echidna. —darklordtrom 04:33, 3 August 2010 (UTC)
Ahaha...I just realized how complicated this template is. I'll try working on it later if I can, if TTE doesn't get to it first. Jello 05:13, 3 August 2010 (UTC)
After tesing the change in my userspace, I've now added a desccoloxd parameter. Werdnae (talk) 07:07, 3 August 2010 (UTC)

Descdp

It needs a descdp parameter, for use with Zoom Lens. It has a different description (and effect) between DP and PtHGSS. --SnorlaxMonster 12:46, 26 May 2010 (UTC)

Parser

There should be a descrsefrlg parser, as some of the key items have the same descriptions. ht14 20:42, 31 May 2010 (UTC)

Roundy corners.

I request that the -moz-border-radius: 10px is changed to {{roundy|10px}}, so every browser is able to read it. wat 12:00, 1 June 2010 (UTC)

Alternate sell prices

I am trying to add the alternate prices of items when sold to the collecters on Route 5, Sekka City, and Sazanami Town, but when I try to add a tooltip I get an expression error. Can someone please fix this?--A Tell-Tale Heart 19:20, 11 December 2010 (UTC)

A bit late, but for future reference, use sellnotes. --SnorlaxMonster 12:02, 26 December 2010 (UTC)

May I suggest...

...that "ONLY IN" should be changed to "EXCLUSIVELY IN"? They mean the same thing, don't they?
~~LDEJRuff~~(see what I have contributed) December 31, 2010, 17:00 (EDT)

If there's no difference, then we don't need to change it... unless there's a certain reason why... ht14 22:02, 31 December 2010 (UTC)

This template and auto expand

So a minor annoyance that I've found consistently throughout this site is when people link to items (a prime example) the page loads with the templates expanded and some JavaScript collapses them, moving the window view down the page since JavaScript executes after the "#" in URL processing.

Example: Apricorn Box → (redirects to) → List of key items in Generation IV#Apricorn_Box

If you click on either of those links, you are brought to the correct location due to <a name="Apricorn_Box"> working in your browser. Then, the page finishes loading and Javascript collapses all of the Item templates, and you are left looking at the bottom of the page, a couple screens away from any apricorn boxes and rather tediously have to do something like "ctrl+F Apricorn Box".

My proposed solution is actually very simple. Use CSS to make this template start off closed!

Change line 39 of this template from:

|-

to:

|- style="display: none;"

It would be nice if a simple change like this could have the Item linked to start off expanded, but alas it doesn't appear to work that way...

I even tested it in an unsaved Show Preview and it works better.

I'm sure there are other templates that should get this treatment, but this specific one is the one I encounter very often.

</rant>

~ Ribose · talk · cntr · 05:32, 20 May 2011 (UTC)

The css coding display:none; does just that. It displays none of it. If that were done, the parts that were set to display:none; would not be able to be viewed at all. Werdnae (talk) 06:48, 20 May 2011 (UTC)
I know this, its supposed to start collapsed... but on line 39, when you click "[show]" it will remove that exact style (check with firebug or whatever you have) and it will work. Should I show you in my userspace?
When it loads, it starts expanded (because this style doesn't exist), but onload() it is set to style="display:none;" via JavaScript. What I'm saying is make sure it starts collapsed so that the anchors work on all browsers correctly.
I just tested, and it seems Firefox does a *better* job than Chrome of moving to the correct view, but is still sometimes inaccurate... ~ Ribose · talk · cntr · 19:29, 20 May 2011 (UTC)
Show me what you're talking about in your userspace then, because I'm not getting what you're trying to say. If you're simply adding style="display:none;" on your testing, then the effect you're seing is due to the page being smaller and therefore loading faster, and you're permanently hiding a component of the template. Werdnae (talk) 20:12, 20 May 2011 (UTC)
All I'm doing is making the the # links work. See User:Ribose/S/Template:Item for it. Notice that if you load the page it starts closed rather than waiting for the page to load completely and then JavaScript closing it. This is less noticable with one template, but much more noticable with the 50 of them on a page like List of key items in Generation IV. I also notice it is much more obvious with Chrome than with any other browser because the others seem to properly keep page position when things above the current page position collapse. ~ Ribose · talk · cntr · 20:50, 20 May 2011 (UTC)
That coding you've added does literally nothing. Even if it were to do anything, it would hide the entire effects and catch rate section. Tell me, does it still have the same effect on a page that is similar in length to other item lists? Werdnae (talk) 21:12, 20 May 2011 (UTC)
I just saw your test and your right, I missed hiding the "Description" block that doesn't exist on the default template (with "cancel"). I'm trying to figure out where my mistake was...
To answer your question, for some reason Chrome centers fine. My guess is because it's near the top (Master Ball is #3). A chose Apricorn Box because it had a large number of templates above it that do collapse.
If this is bothering you, sorry. :( ~ Ribose · talk · cntr · 21:19, 20 May 2011 (UTC)
Looks like there are actually three tr's ("|-"s) that need to be given display:none;. Lines 132 and 206 might do that, not 100% sure yet.
In case I'm still not clear: All this is for BEFORE the page completes loading and runs the JavaScript. You should test it in Chrome if you haven't already, because Firefox seems to properly keep scroll location after content has collapsed above the current view fine most of the time. ~ Ribose · talk · cntr · 21:34, 20 May 2011 (UTC)
It doesn't work that way. The reason javascript is used for the show/hides is because CSS like that can't be modified without reloading the page. The coding to set it to display:none; doesn't hide it on the page load. It hides it permanently. using css to hide those sections will mean that clicking the javascript showhiders doesn't open them. Setting it do display:none; can't fix the issue without destroying the template. Werdnae (talk) 21:36, 20 May 2011 (UTC)
You're saying style="display:none;" on the <tr> is permanent? If that were so, you'd only see the description section when you clicked "[show]" on User talk:Ribose/S/Template:Item if it remains unmodified at this time. Chrome, Firefox, and even Internet Explorer disagree with you. Take a look at Chrome's inspect element when you click show/hide. It ultimately adds and removes "display: none" from the <tr>s which I'm just giving a starting state (closed).
If you will, I can now safely fix it so the description row and the notes row start hidden (before JavaScript) too, though it'd be another userspace edit. ~ Ribose · talk · cntr · 21:57, 20 May 2011 (UTC)
*sigh*, I need to learn to shut up and listen when people start talking about javascript. It does appear you're right. My apologies. I'll see if I can get a staff member who actually knows some javascript to double check before it gets added. Oh, and just for future reference, saying "line 39" isn't as specific as you might like it to be, due to text wrapping. Werdnae (talk) 10:47, 21 May 2011 (UTC)
It's okay.
I was assuming you had an external editor like Notepad++ which tells you line numbers (and has other cool features).
As it is now, it looks like mine should work for all rows that I know about: Effect row, optional Secondary Effect row, optional Description row, optional Notes row, and optional "please see the main article" row. If there are any others, I'm sure the person to do the actual change knows of them. ~ Ribose · talk · cntr · 15:47, 22 May 2011 (UTC)
Sorry, I completely forgot about this. Thanks to Firebug, I could see for myself that you were right, so I added it in. Werdnae (talk) 01:39, 22 July 2011 (UTC)